fix(registry): add timeout and use HEAD request in registryValidation#2087
Open
sungdark wants to merge 2 commits intoasyncapi:masterfrom
Open
fix(registry): add timeout and use HEAD request in registryValidation#2087sungdark wants to merge 2 commits intoasyncapi:masterfrom
sungdark wants to merge 2 commits intoasyncapi:masterfrom
Conversation
added 2 commits
March 25, 2026 15:29
Fixes asyncapi#2027 - Added AbortController with 10 second timeout to prevent indefinite hangs - Changed from GET to HEAD request for lighter weight validation - Improved error messages to preserve original error and indicate timeout
Fixes asyncapi#2027 - CLI hangs indefinitely when --registry-url points to an unreachable host (no timeout handling). Changes: - Add AbortController with 5s timeout to prevent indefinite hangs - Use HEAD request instead of GET for lighter network footprint - Provide meaningful error message on timeout (shows URL and timeout) - Add unit tests for registryURLParser and registryValidation - Test timeout behavior against blackhole IP (10.255.255.1)
sungdark
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2027 - CLI hangs indefinitely when
--registry-urlpoints to an unreachable host (no timeout handling).Changes
Registry URL timed out after 5s: <url>. The host is unreachable or too slow.registryURLParserandregistryValidationincluding timeout behaviorRoot Cause
The original
registryValidation()insrc/utils/generate/registry.tscalledfetch()without:AbortController/ timeoutTesting
Files Changed
src/utils/generate/registry.ts— add timeout, use HEAD, proper error messagestest/unit/utils/registry.test.ts— new unit tests